Add 2fa to Invidious in the form of TOTP#2254
Open
syeopite wants to merge 22 commits intoiv-org:masterfrom
Open
Add 2fa to Invidious in the form of TOTP#2254syeopite wants to merge 22 commits intoiv-org:masterfrom
syeopite wants to merge 22 commits intoiv-org:masterfrom
Conversation
SamantazFox
reviewed
Jul 16, 2021
SamantazFox
reviewed
Jul 16, 2021
Member
Author
|
Requires automatic migration system |
|
This pull request has been automatically marked as stale and will be closed in 30 days because it has not had recent activity and is much likely abandoned or outdated. If you think this pull request is still relevant and applicable, you just have to post a comment and it will be unmarked. |
syeopite
force-pushed
the
security-improvements
branch
from
c8c35e1 to
7d5e809
Compare
Member
Author
|
Rebased. I believe the PR is still being blocked by a lack of an automatic migration system. Though it should work if you manually run |
Member
Author
|
On another note, purely for readability and consistency reasons, I feel like most of the methods added here should be renamed and properly documented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #418
The only problem with this PR currently is that users would have to manually enter the base32 secret since we don't have a way to construct QR codes without adding another dependency to Invidious.
I've also went ahead and moved some of the account related views to their own folder.
This shouldn't be merged until #1678 due to the requirement of a migration script.